Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly format tags in the welcome screen's example card #5783

Closed
abey79 opened this issue Apr 4, 2024 · 4 comments · Fixed by #5802
Closed

Properly format tags in the welcome screen's example card #5783

abey79 opened this issue Apr 4, 2024 · 4 comments · Fixed by #5802
Assignees
@emilk
Labels
ui concerns graphical user interface
Milestone
0.15

Comments

@abey79
Copy link
Member

abey79 commented Apr 4, 2024

In app vs web, notice the difference in tag formatting:

image image

We need to capitalise and remove -
@abey79 abey79 added the ui concerns graphical user interface label Apr 4, 2024
@abey79 abey79 added this to the 0.15 milestone Apr 4, 2024
@abey79 abey79 mentioned this issue Apr 4, 2024
Merged
5 tasks
@emilk emilk self-assigned this Apr 4, 2024
@emilk
Copy link
Member

emilk commented Apr 4, 2024

Blocked by #5779 (will lead to too much merge conflicts)

@abey79
Copy link
Member Author

abey79 commented Apr 4, 2024

My idea was to do that in the UI code rather than actually changing all tags. That's apparently how it's done for the landing page.

@abey79
Copy link
Member Author

abey79 commented Apr 4, 2024

Not convinced this is 0.15 blocking, though—just added to the milestone for visibility.

@emilk
Copy link
Member

emilk commented Apr 4, 2024

We decided on https://rerunio.slack.com/archives/C04UBTMMGJK/p1712250738168869 to not do any conversions, and instead use Human case directly in the frontmatter.

@abey79 abey79 mentioned this issue Apr 5, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue Apr 5, 2024
@abey79
Change all example tags to "Human case" (#5802)
695e195 
### What

- Closes #5783

@jprochazk is there some tag formatting code on landing that you could
remove?

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5802)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5802?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5802?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5802)
- [Docs
preview](https://rerun.io/preview/34e4cbca92fdcf792bea86f63ffd10e742f1706b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/34e4cbca92fdcf792bea86f63ffd10e742f1706b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
ui concerns graphical user interface
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Change all example tags to "Human case" rerun-io/rerun
2 participants
@emilk @abey79