-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial TurtleBot subscriber demo #1523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great, though obviously I know nothing about ROS.
Would it be possible to put all the ROS stuff in a Dockerfile, run it in headless mode in a container and connects to from the Rerun script? That would make experimenting with this a whole lot simpler.
Note from @nikolausWest : we should make sure this fails gracefully for users that don't have ROS installed since unlike the other examples the pip requirements alone are insufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Just a fairly minimal mapping of assorted ros topics to corresponding rerun log statements.
Each message also uses tf2 to look up and log a transform for the correct point in time.
We log the point-cloud twice: once in the robot-frame and once in the map-frame as a workaround for #1522
TODO:
Checklist