Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: early exit missing components at table level #1554

Merged
merged 2 commits into from
Mar 10, 2023
Merged

datastore: early exit missing components at table level #1554

merged 2 commits into from
Mar 10, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 10, 2023

This is a partial fix for #1545: it takes care of the O(n) backward walk when querying for non-existing components, but it doesn't explain why there are that many buckets in the first place when running the clocks example (that's another problem for another PR).

Bench:
image

clocks in debug:
image

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🚀 performance Optimization, memory use, etc labels Mar 10, 2023
Wumpf
Wumpf approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straight forward! 👍

@Wumpf Wumpf merged commit 416cb36 into main Mar 10, 2023
@Wumpf Wumpf deleted the cmc/index_table_early_exit branch March 10, 2023 10:35
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🚀 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf