Stop using infinities in wgsl shaders #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rendering issues on Windows browsers (likely due to a bug in ANGLE?). However this operation is undefined by spec anyways. Instead we're now using float min/max instead. Wgsl float constants are now following wgsl spec to the letter.
Wumpf
added
🪳 bug
emilk
approved these changes
Mar 15, 2023
|
Related to #1195 |
This was referenced Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rendering issues on Windows browsers (likely due to a bug in ANGLE?). However this operation is undefined by spec anyways. Instead we're now using float min/max instead. Wgsl float constants are now following wgsl spec to the letter.
Checklist