Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hover things in 2D/3D views if we are dragging something #1643

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Don't hover things in 2D/3D views if we are dragging something #1643

merged 1 commit into from
Mar 21, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 21, 2023

Closes #1185

…and unlike previous attempts, click-to-select still works

Checklist

@emilk
Don't hover things in 2D/3D views if we are dragging something
5e68e1f 
Closes #1185

…and unlike previous attempts, click-to-select still works
@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Mar 21, 2023
@teh-cmc teh-cmc self-requested a review March 21, 2023 13:38
teh-cmc
teh-cmc approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

Wumpf
Wumpf approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed as well!

@Wumpf Wumpf merged commit e41c992 into main Mar 21, 2023
@Wumpf Wumpf deleted the emilk/fix-drag-is-hovering branch March 21, 2023 14:08
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't trigger hover when dragging scene to rotate
3 participants
@emilk @Wumpf @teh-cmc