Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow input for running benchmarks manually #1698

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 23, 2023

Checklist

@jleibs jleibs marked this pull request as ready for review March 23, 2023 18:37
@jleibs jleibs force-pushed the jleibs/manual_benchmarks branch from 8296230 to 93cc69e Compare March 23, 2023 18:38
@jleibs jleibs added the 🧑‍💻 dev experience developer experience (excluding CI) label Mar 23, 2023
# Only save the rs-benchmarks job when a commit gets pushed to main
if: ${{ github.event_name == 'push' }}
# Only run the rs-benchmarks job when a commit gets pushed to main or we manually specify it
if: ${{ github.ref == 'refs/heads/main' || github.event.inputs.force_run_benchmarks }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ref == 'refs/heads/main' is a bit more inline with the actual spirit than any push.

@jleibs jleibs merged commit d96204c into main Mar 23, 2023
@jleibs jleibs deleted the jleibs/manual_benchmarks branch March 23, 2023 18:59
@jleibs jleibs mentioned this pull request Mar 23, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants