Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transforms not applied to connections from transform context #2407

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix transforms not applied to connections from transform context #2407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/re_space_view_spatial/src/scene/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ pub fn preferred_navigation_mode(

pub fn load_keypoint_connections(
ent_context: &SpatialSceneEntityContext<'_>,
entity_path: &re_data_store::EntityPath,
ent_path: &re_data_store::EntityPath,
keypoints: Keypoints,
) {
if keypoints.is_empty() {
Expand All @@ -95,7 +95,8 @@ pub fn load_keypoint_connections(
let mut line_builder = ent_context.shared_render_builders.lines();
let mut line_batch = line_builder
.batch("keypoint connections")
.picking_object_id(re_renderer::PickingLayerObjectId(entity_path.hash64()));
.world_from_obj(ent_context.world_from_obj)
.picking_object_id(re_renderer::PickingLayerObjectId(ent_path.hash64()));

for ((class_id, _time), keypoints_in_class) in keypoints {
let Some(class_description) = ent_context.annotations.context.class_map.get(&class_id) else {
Expand All @@ -111,7 +112,7 @@ pub fn load_keypoint_connections(
let (Some(a), Some(b)) = (keypoints_in_class.get(a), keypoints_in_class.get(b)) else {
re_log::warn_once!(
"Keypoint connection from index {:?} to {:?} could not be resolved in object {:?}",
a, b, entity_path
a, b, ent_path
);
continue;
};
Expand Down