Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude from objectron/proto/objectron/proto.py from just py-format #2562

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Exclude from objectron/proto/objectron/proto.py from just py-format #2562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1273a12
Exclude `objectron/proto/objectron/proto.py` from pyupgrade
abey79 Jun 29, 2023
4d0b2b4
link to PR in comment
emilk Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ py-format:
set -euxo pipefail
black --config rerun_py/pyproject.toml {{py_folders}}
blackdoc {{py_folders}}
pyupgrade --py38-plus `find {{py_folders}} -name "*.py" -type f`
# Note: proto.py relies on old-style annotation to work, and pyupgrade is too opinionated to be disabled from comments
# See https://github.com/rerun-io/rerun/pull/2559 for details
pyupgrade --py38-plus `find {{py_folders}} -name "*.py" -type f ! -path "examples/python/objectron/proto/objectron/proto.py"`
ruff --fix --config rerun_py/pyproject.toml {{py_folders}}

# Check that all the requirements.txt files for all the examples are correct
Expand Down