Depth map support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for logging depth maps in the SDK.
However, at the moment they are not displayed any different in the viewer. We still need to figure out what is a good way to display them. One key thing one would want to do is to be able to use a picker to sample the depth map and show the depth. I think it would make sense to always have the picker enabled when hovering over an image (depth or otherwise) in the 2D view.
At the moment the "picker" functionality is only enabled when hovering tensor data, but at the level where the tensor has no meta-data to say whether or not it is a depth map. I think there is value to such "raw" inspection too, but it is probably going to be a far less common usecase.