Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ check commands in contrib CI and readme #3858

Merged
merged 2 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/contrib_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -282,15 +282,14 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Build and run C++ minimal example
shell: bash
run: ./examples/cpp/minimal/build_and_run.sh --werror

- name: Build and run rerun_cpp tests
shell: bash
run: ./rerun_cpp/build_and_run_tests.sh --werror

- name: Build code examples
- name: Build examples
shell: bash
run: ./docs/code-examples/build_all.sh --werror
run: ./examples/cpp/build_all.sh --werror

- name: Build doc-code examples
shell: bash
run: ./docs/code-examples/cpp_build_all.sh --werror
1 change: 1 addition & 0 deletions docs/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@
"webgpu",
"webm",
"webpki",
"werror",
"wgpu",
"wgsl",
"whele",
Expand Down
2 changes: 1 addition & 1 deletion rerun_cpp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This is not yet ready to be used.
Run `scripts/setup.sh`.

## Test it
`examples/cpp/minimal/build_and_run.sh`
`./rerun_cpp/build_and_run_tests.sh --werror`

# To do:
* CI
Expand Down
2 changes: 1 addition & 1 deletion scripts/check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ typos
cargo fmt --all -- --check
./scripts/lint.py
./scripts/ci/cargo_deny.sh
./examples/cpp/minimal/build_and_run.sh --werror
./rerun_cpp/build_and_run_tests.sh --werror
just py-lint

cargo check --all-targets --all-features
Expand Down
Loading