Release 0.11 #4347
Merged
Release 0.11 #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
force-pushed
the
release-0.11.0
branch
from
5a1e238
to
1577491
Compare
* Closes #4315 Adds: * Open Photogrammetry Example * External C++ VRS example * External C++ Eigen/OpenCV exaple I also opted to sort the examples in lexicographical order because it's in my DNA to do so. Check the "Examples preview" below ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4342) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4342) - [Docs preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/1598cc75e9a913ae43866e2ab570ea9cce0d4110/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
|
Testing the python wheels: The manifest seems to be wrong / rrd files not uploaded to the right place. When I click an example it doesn't load and gives this error: |
That's this is related to the rrd upload issue we had during the release ci, should be resolved on the next RC. But I'm very confused now to why this works on the Rust build I tried 🤔 |
…ity (#4354) ### What Was accidentally looking up groups as individual entities. In particular this broke visible history configuration on a group selection. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4354) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4354) - [Docs preview](https://rerun.io/preview/200482e934335f0c7169e62aa934e1011b996366/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/200482e934335f0c7169e62aa934e1011b996366/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
### What Empty is a more robust check than null since it also catches the empty string. I'm torn on whether to also check for null here -- my inclination is not to since I'd rather raise the unexpected null error since if someone is passing an StringView with a nullptr but non-zero length, they are doing something wrong. * closes #4348 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4349) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4349) - [Docs preview](https://rerun.io/preview/91d08d9950b844e4ac02c0214c7bfe3a54d3bee1/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/91d08d9950b844e4ac02c0214c7bfe3a54d3bee1/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
### What
Running cmake for an unziped rerun c++ sdk package would yield this
warning:
```
CMake Warning (dev) in CMakeLists.txt:
No project() command is present. The top-level CMakeLists.txt file must
contain a literal, direct call to the project() command. Add a line of
code such as
project(ProjectName)
near the top of the file, but after cmake_minimum_required().
CMake is pretending there is a "project(Project)" command on the first
line.
This warning is for project developers. Use -Wno-dev to suppress it.
```
looks like there's no harm in just calling `project` again, even if the
cmake file is in the context of the our repo
### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4350) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
- [PR Build Summary](https://build.rerun.io/pr/4350)
- [Docs
preview](https://rerun.io/preview/bf7558dce2c269d2873b2496beb67bdf745a4878/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bf7558dce2c269d2873b2496beb67bdf745a4878/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
### What Needed for cmake install on windows if there's spaces on any of the relevant paths. This happens because unlike when using a cmake variable, here the @value@ identifiers are replaced with the actual variable value which may contain spaces ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4351) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4351) - [Docs preview](https://rerun.io/preview/21599dd24a1940681fee718be930ecedeb9577f4/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/21599dd24a1940681fee718be930ecedeb9577f4/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79
reviewed
Nov 28, 2023
abey79
reviewed
Nov 28, 2023
emilk
reviewed
Nov 28, 2023
|
working on a code sandbox example to add to the JS docs |
4 tasks
jprochazk
added
the
exclude from changelog
|
JS build will always fail because it starts sooner than the npm publish finishes. It succeeds if we restart it once the publish is done |
|
What were the biggest issues in this release? From my perspective it was:
There were some smaller snags in the new release stuff (e.g. npm publish failing), but the two above caused the most problems... |
|
agreed! The issues we had on our side were all annoying but don't concern me that much. We primarily need to improve a bit on on our internal documentation so it's easier to troubleshoot if @jprochazk is not around 😄. And release more often to get more kinks out. But overall our tooling has been great I think |
teh-cmc
pushed a commit
that referenced
this pull request
Nov 30, 2023
### What * Fixes #4267 TODO for final release: * [x] Update links, fix all `?speculative-link` * [x] cherry pick #4349 * [x] cherry pick #4350 * [x] cherry pick #4351 * [x] cherry pick #4354 * [x] Write changelog (and review thereof) * Known limitation of Visible History worth mentioning: * [x] #4270 * [x] #723 * [x] testing: * special care this time about: * Blueprint error messages (use outdated stuff you have on your machine to stretch it!) * UI changes (selection panel, visual history things - in particular on the plot) * C++ cmake install (follow public instructions - if they don't help the instructions are bad!) * [x] Windows * [x] Native * blueprint ok 0.10.0-rc.1 -> 0.11-rc.1 * found spurious wgpu related crash, seems to be fixed on latest wgpu. Details on Slack * C++ visual studio project for unziped sdk works * Cmake install works. With path with spaces after applying #4351 * [x] Browser * [x] Linux * [x] Native * [x] Browser * [x] Mac * [x] Native * [x] blueprint ok 0.10.1 -> 0.11 * [x] UI changes ok * [x] Browser * [x] python package (any platform) * [x] tested on mac, seems ok except: * [x] ~~couldn't load example rrds~~ fixed * [x] C++ cmake install (any platform) * tested on linux * [x] Rust crate (any platform) * [x] finish opencv/eigen example update TODO just after release: * [x] Update webpage with blog * [x] Merge opencv/eigen example update * [x] github release update * [x] post on social ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [app.rerun.io](https://app.rerun.io/pr/4347) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4347) - [Docs preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/01b4186b37fc910491879dfd90433aeb940a5c89/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> Co-authored-by: rerun-bot <bot@rerun.io> Co-authored-by: jprochazk <1665677+jprochazk@users.noreply.github.com> Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TODO for final release:
?speculative-linkegui_plotauto-bounds state after dragging the time cursor in timeseries space views #4270couldn't load example rrdsfixedTODO just after release:
Checklist