Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly builds #4505

Merged
merged 49 commits into from
Dec 14, 2023
Merged

Nightly builds #4505

merged 49 commits into from
Dec 14, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Dec 13, 2023 •
edited by github-actions bot
Loading

What

  • Rename existing nightly to main
  • Add nightly build which runs once per day
  • Build all examples in nightly build
  • Build only quick examples in main build

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jprochazk jprochazk added include in changelog 🚢 CI examples Issues relating to the Rerun examples labels Dec 13, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Size changes

Name main 4505/merge Change
detect_and_track_objects.rrd 55.22 MiB (deleted) -100%

emilk
emilk approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I can take a pass on shrinking the .rrd sizes.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
ARCHITECTURE.md Outdated Show resolved Hide resolved
examples/python/detect_and_track_objects/README.md Outdated Show resolved Hide resolved
crates/re_examples/src/lib.rs Outdated Show resolved Hide resolved
crates/re_examples/src/lib.rs Outdated Show resolved Hide resolved
crates/re_examples/src/lib.rs Outdated Show resolved Hide resolved
crates/re_examples/src/lib.rs Outdated Show resolved Hide resolved
crates/re_examples/src/lib.rs Outdated Show resolved Hide resolved
@jprochazk
Copy link
Member Author

It seems like argh isn't adding much to the compile times

@jprochazk jprochazk requested a review from emilk December 14, 2023 14:39
emilk
emilk approved these changes Dec 14, 2023
View reviewed changes
.github/workflows/nightly.yml
Comment on lines +7 to +8
# 12:15 UTC, every day
- cron: "15 12 * * *"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so "nightly" means… slightly after noon 😆 I guess it's always night somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this way we get to react to any build failures

crates/re_build_examples/Cargo.toml Outdated Show resolved Hide resolved
@jprochazk jprochazk merged commit 2e99a7b into main Dec 14, 2023
40 checks passed
@jprochazk jprochazk deleted the jan/nightly-builds branch December 14, 2023 16:43
This was referenced Dec 14, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples include in changelog 🚢 CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprochazk @emilk