Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aspect ratio check from upload_image.py #5806

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Apr 5, 2024

What

That check dates back from when we used the screenshot as thumbnail, so we needed it to have some sensible aspect ratio. That's history now, and bypassing this check every time is most annoying.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@abey79 abey79 added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 5, 2024
@abey79 abey79 merged commit ee51fe8 into main Apr 5, 2024
39 checks passed
@abey79 abey79 deleted the antoine/remove-ar-check branch April 5, 2024 14:56
jleibs pushed a commit that referenced this pull request Apr 5, 2024
### What

That check dates back from when we used the screenshot as thumbnail, so
we needed it to have some sensible aspect ratio. That's history now, and
bypassing this check every time is most annoying.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5806)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5806?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5806?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5806)
- [Docs
preview](https://rerun.io/preview/3382c7c3964426d42115a8b9e3476c313145a153/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3382c7c3964426d42115a8b9e3476c313145a153/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants