Improve bundling of web-viewer
package
#6659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It turns out that the following issue is actually two different memory leaks in a trench coat:
This PR addresses the 2nd one, by changing the way we output and bundle the
rerun-io/web-viewer
package:new URL("./local_file.js", import.meta.url)
pattern to resolve the.wasm
file's URL at bundle time, andfetch
it at runtime. (Side note: we can use this to expose progress tracking for Slow loading without indicator radames/gradio-rerun-viewer#5)local_file.js
in the import graph as if it was loaded lazily, and return its final URL"esbuild
: URL assets bundling evanw/esbuild#795wasm-bindgen
, the output is further processed to ensure that the top-level globals (such as the leak-causingheap
Memory leak when repeatedly instantiating a WASM module rustwasm/wasm-bindgen#3130) are not actually global, and instead can be instantiated once per Wasm instance.To support usage in
rerun_notebook
and other environments which do not support thenew URL
pattern, theindex.js
,re_viewer.js
, andre_viewer_bg.wasm
files are concatenated into a singleinlined.js
file.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.