Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Datatype and DatatypeBatch #7256

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Remove unused Datatype and DatatypeBatch #7256

merged 2 commits into from
Aug 23, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 23, 2024 •
edited
Loading

Remove unused old traits.

Part of a lot of clean up I want to while we head towards:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🚜 refactor Change the code, not the functionality include in changelog labels Aug 23, 2024
Wumpf
Wumpf approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@teh-cmc teh-cmc merged commit 2e2a988 into main Aug 23, 2024
36 checks passed
@teh-cmc teh-cmc deleted the cmc/get_rid_of_stuff_1 branch August 23, 2024 10:47
@teh-cmc teh-cmc changed the title Remove Datatype and DatatypeBatch Remove unused Datatype and DatatypeBatch Aug 28, 2024
emilk added a commit that referenced this pull request Aug 28, 2024
@emilk
Revert "Remove Datatype and DatatypeBatch (#7256)"
0c06ff7 
This reverts commit 2e2a988.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf