Remove unused LoggableBatch::num_instances
#7258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
do-not-merge
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/10525533441 |
teh-cmc
force-pushed
the
cmc/get_rid_of_stuff_3
branch
from
77390c5
to
df8416c
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/10526023117 |
emilk
approved these changes
Aug 23, 2024
teh-cmc
force-pushed
the
cmc/get_rid_of_stuff_3
branch
from
df8416c
to
fac47d2
Compare
teh-cmc
changed the title
LoggableBatch::num_instancesLoggableBatch::num_instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggableBatch::num_instancesis a deprecated remnant from theInstanceKeydays that doesn't make sense anymore.The number of instances is the length of the top-level
ComponentBatcharray, always.Part of a lot of clean up I want to while we head towards:
Archetype&ComponentBatchserialization in Rust and C++ #7245re_arrow2toarrow#3741Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.