Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dataframe streaming across Python FFI #7935

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 29, 2024

Title.

Just trying not to bury the actual important thing into the previous mammoth PR 🫠

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🐍 Python API Python logging API do-not-merge Do not merge this PR include in changelog feat-dataframe-api Everything related to the dataframe API labels Oct 29, 2024
@teh-cmc teh-cmc force-pushed the cmc/dataframe_streamings branch 2 times, most recently from fcf0869 to b0bc72c Compare October 29, 2024 17:23
@teh-cmc teh-cmc marked this pull request as ready for review October 29, 2024 17:33
@teh-cmc teh-cmc force-pushed the cmc/storage_engine branch from 25ad40f to fc310cc Compare October 29, 2024 18:00
@teh-cmc teh-cmc force-pushed the cmc/dataframe_streamings branch from b0bc72c to 18da4aa Compare October 29, 2024 18:00
@rerun-io rerun-io deleted a comment from github-actions bot Oct 29, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 29, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11579787308

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR only removes code, but the code it removes are /* */ pairs… is it removing code, or adding it? 🧘

@teh-cmc teh-cmc force-pushed the cmc/dataframe_streamings branch from 18da4aa to 6911620 Compare October 30, 2024 08:31
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 30, 2024

If a forest falls but also a tree does it sound, yes?

@teh-cmc teh-cmc force-pushed the cmc/storage_engine branch from f417f9d to 2fc33cc Compare October 31, 2024 08:43
@teh-cmc teh-cmc force-pushed the cmc/dataframe_streamings branch from 6911620 to 88312ca Compare October 31, 2024 08:44
Base automatically changed from cmc/storage_engine to main October 31, 2024 09:02
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Oct 31, 2024
@teh-cmc teh-cmc force-pushed the cmc/dataframe_streamings branch from 88312ca to d60c862 Compare October 31, 2024 09:03
@teh-cmc teh-cmc merged commit 36d7553 into main Oct 31, 2024
28 checks passed
@teh-cmc teh-cmc deleted the cmc/dataframe_streamings branch October 31, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dataframe-api Everything related to the dataframe API include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants