Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message style slightly #8092

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Improve error message style slightly #8092

merged 5 commits into from
Nov 12, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 12, 2024

What

Before, the error style was inconsistent and ugly:
image

Now it is consistent and ever so slightly less ugly:
image

We can do better though, in

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog 🧑‍🎨 Design Requires UX/UI designer input labels Nov 12, 2024
@Wumpf Wumpf self-requested a review November 12, 2024 10:25
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emilk emilk changed the title Improve error message style Improve error message style slightly Nov 12, 2024
@emilk emilk merged commit ff248a4 into main Nov 12, 2024
37 checks passed
@emilk emilk deleted the emilk/imrove-errors branch November 12, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍🎨 Design Requires UX/UI designer input include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants