Remove dead code: Hash128
#8203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🪳 bug
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
requested changes
Nov 22, 2024
| @@ -91,7 +86,7 @@ impl Hash128 { | |||
| impl std::hash::Hash for Hash128 { | |||
| #[inline] | |||
| fn hash<H: std::hash::Hasher>(&self, state: &mut H) { | |||
| state.write_u64(self.0[0]); | |||
| state.write_u128((self.first64() as u128) << 64 | self.second64() as u128); | |||
There was a problem hiding this comment.
IIRC, you're only allowed to use write_u64 with nohash_hasher, anything else will result in a runtime error in debug builds.
If the hash128 is good, than any 64 bits of it should also be a good hash
|
If |
|
Let's remove it then. |
emilk
added
🚜 refactor
emilk
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash128isn't actually used anywhere, I just randomly stumbled upon it while refactoring some hashing related stuff.Still a good idea to fix it (or remove it entirely?) before someone's get bitten.