Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command for running python build in BUILD.md #8209

Closed
wants to merge 2 commits into from

Conversation

jviereck
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.

@abey79
Copy link
Member

abey79 commented Nov 28, 2024

Hello. Thanks for your contribution. Unfortunately, your change suggestion is incorrect: this command does not produce an installable wheel. We were currently lacking such a command, so I introduced one and updated the BUILD.md instructions accordingly. For some reason, I was unable to push these changes to the present PR, so I opened a new one here:

@abey79 abey79 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants