Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build npm package with map_view,grpc features #8225

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

jprochazk
Copy link
Member

The npm package build script didn't include some feature flags which means currently the map view snippet in docs in unusable.

@jprochazk jprochazk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser labels Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
0caea85 https://rerun.io/viewer/pr/8225

Note: This comment is updated whenever you push a commit.

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jprochazk jprochazk merged commit e554f41 into main Nov 26, 2024
27 checks passed
@jprochazk jprochazk deleted the jan/fix-map-view-snippet branch November 26, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants