Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of 1.83.0 clippy stuff #8244

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix a bunch of 1.83.0 clippy stuff #8244

merged 1 commit into from
Nov 29, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 28, 2024

cargo +1.83.0 clippy --fix did most of the work; I did some of it manually

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
✅ 3c8b1ef https://rerun.io/viewer/pr/8244

Note: This comment is updated whenever you push a commit.

Wumpf
Wumpf approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emilk emilk merged commit f81b42e into main Nov 29, 2024
38 checks passed
@emilk emilk deleted the emilk/1.83.0-clippy-fixes branch November 29, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf