Add a snapshot test for list items #8248
Conversation
abey79
added
🔨 testing
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| re_ui::apply_style_and_install_loaders(ui.ctx()); | ||
| list_item::list_item_scope(ui, "list_item_scope", &mut test_code); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Food for thought: it would be nice if we could set things up so that some screenshots tests (like this one) would also be actually runnable (for additional manual testing).
I don't know how (maybe @lucasmerlin has a good idea?), but it would be cool.
In this case I guess the test could actually call some piece of code shared with re_ui_example.
Anyways, not necessary for this PR obviously, just an interesting idea imho
There was a problem hiding this comment.
I already thought about something like this, I think we could allow this for all tests, just running the app closure via eframe before the test is executed. This could be enabled via a feature and an environment variable like DEBUG_TESTS or as a method on harness.
Edit: The weird thing is that now there would be two different egui contexts, which will probably lead to unexpected results in complex uis. Not sure if we could pass an existing egui Context to eframe and tell it to use that somehow
There was a problem hiding this comment.
Gave this a try, I don't think this will be easily possible 🥲
on macOS, `EventLoop` must be created on the main thread!
But maybe we could use https://github.com/emilk/eterm? 😄 Perfect usecase for that. That might also be able to solve the two context problem
What
snapshot: