Automatically generate partial update APIs for eager archetypes #8647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
teh-cmc
added
🦀 Rust API
teh-cmc
force-pushed
the
cmc/eager_partial_3_eager_archetypes
branch
from
15b27bd to
159b53f
Compare
teh-cmc
force-pushed
the
cmc/eager_partial_4_partial_on_eager
branch
from
a1331e1 to
d5bc79c
Compare
teh-cmc
added a commit
that referenced
this pull request
Jan 13, 2025
Store-side compaction has election heuristics that can yield different results depending on the order in which the chunks arrive. This can make some cross-language roundtrip tests flaky. This PR makes sure to disabled store-side compaction when running RRD comparison tests. * DNM: requires #8647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the codegen of the
attr.rust.archetype_eagerattribute so that it automatically generates partial updates APIs for all eager archetypes.