Eagerly serialized, partially updatable 2D & 3D line strips #8650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
teh-cmc
added
🦀 Rust API
teh-cmc
force-pushed
the
cmc/eager_partial_7_linestrips
branch
from
19b3032 to
e067f32
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12713445477 |
emilk
approved these changes
Jan 10, 2025
| components::LineStrip2D::from_iter([[0., 3.], [1., 4.], [2., 2.], [3., 4.], [4., 2.], [5., 4.], [6., 3.]]), // | ||
| ] | ||
| .serialized() | ||
| .map(|batch| batch.with_descriptor_override(LineStrips2D::descriptor_strips())), |
There was a problem hiding this comment.
Ah right, we need to do this manually in the tests now… oh well
There was a problem hiding this comment.
Well, we only need to do it for that specific test because that's the thing I'm testing for. In any other case I sure hope people will use the builder methods!
teh-cmc
force-pushed
the
cmc/eager_partial_6_and_snippets_for_all
branch
from
55800f3 to
ba709f9
Compare
Base automatically changed from
cmc/eager_partial_6_and_snippets_for_all
to
main
January 13, 2025 08:45
teh-cmc
force-pushed
the
cmc/eager_partial_7_linestrips
branch
from
e067f32 to
e30aa4b
Compare
teh-cmc
added a commit
that referenced
this pull request
Jan 14, 2025
…+ partial (#8666) Introduces a new attribute that, when paired with an eager archetype, will also generate a native companion type with back-and-forth conversion methods. This is especially useful for blueprint archetypes (although there are definitely non-blueprint examples too), which are heavily used all across the viewer, and would be very painful to use otherwise. ```rust /// Whether we should generate an extra Rust object comprised of native Rust types. /// /// The generated object will have the name of the archetype, prefixed by `Native`, /// e.g. `NativePoints3D`. /// /// Applies only to *eager* archetypes. No-op otherwise. attribute "attr.rust.archetype_native"; ``` With this, we now should have all the tools required to port every remaining archetype (both blueprint and data). * Part of #8650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
LineStrips2DandLineStrips3Deagerly serialized and partially update-able.This demonstrates how to migrate an archetype in the simple case.