Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRD manifests bootstrap #9053

Merged
merged 2 commits into from
Feb 19, 2025
Merged

RRD manifests bootstrap #9053

merged 2 commits into from
Feb 19, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 17, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 46fbe52 https://rerun.io/viewer/pr/9053 +nightly +main

Note: This comment is updated whenever you push a commit.

teh-cmc
teh-cmc commented Feb 17, 2025
View reviewed changes
crates/store/re_format_arrow/src/lib.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean that up and make a quick PR for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/store/re_log_encoding/src/codec/arrow.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be any reason not to use arrow1 everywhere anymore? Should try to make a standalone PR to remove all of this.

Copy link
Member Author

@teh-cmc teh-cmc Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now that PR cannot be merged, but I need this to be true in order to fix my metadata issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/store/re_log_encoding/src/decoder/streaming.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a dedicated PR, and ideally a test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/store/re_protos/proto/rerun/v0/remote_store.proto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world, all of this new unstable manifest stuff should never make it into the main repo's proto definitions.

@teh-cmc teh-cmc force-pushed the cmc/rrd_index_investigations branch 14 times, most recently from 50146b0 to 0903f7a Compare February 19, 2025 10:19
@teh-cmc teh-cmc changed the title RRD manifest playground RRD manifests bootstrap Feb 19, 2025
@teh-cmc teh-cmc force-pushed the cmc/rrd_index_investigations branch from 0903f7a to 77548af Compare February 19, 2025 10:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

Latest documentation preview deployed successfully.

Result Commit Link
✅ 46fbe52 https://landing-phy1veukc-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc marked this pull request as ready for review February 19, 2025 11:46
@teh-cmc teh-cmc requested a review from zehiko February 19, 2025 11:46
@teh-cmc teh-cmc force-pushed the cmc/rrd_index_investigations branch from 77548af to b06e556 Compare February 19, 2025 11:57
@teh-cmc teh-cmc force-pushed the cmc/rrd_index_investigations branch from b06e556 to cef10d6 Compare February 19, 2025 12:13
zehiko
zehiko approved these changes Feb 19, 2025
View reviewed changes
crates/store/re_protos/proto/rerun/v0/remote_store.proto
Comment on lines +288 to +294
QueryManifestLatestAtRelevantChunks latest_at = 300;

// If specified, will perform a range query with the given parameters.
//
// Incompatible with `latest_at`.
QueryManifestRangeRelevantChunks range = 400;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understood, "incompatible" here means that these 2 are mutually exclusive and both shouldn't be defined? if so, have you chosen not to use oneof intentionally cause it comes with some obvious downsides? if nothing else, less ergonomic to use and forward breaking changes (although not sure how relevant that would be here)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes to all three of these questions.

@teh-cmc teh-cmc added exclude from changelog PRs with this won't show up in CHANGELOG.md dataplatform Rerun Data Platform integration labels Feb 19, 2025
@teh-cmc teh-cmc merged commit 773e9cc into main Feb 19, 2025
45 of 46 checks passed
@teh-cmc teh-cmc deleted the cmc/rrd_index_investigations branch February 19, 2025 14:19
jprochazk added a commit that referenced this pull request Feb 19, 2025
@jprochazk
Revert "RRD manifests bootstrap (#9053)"
b6566bf 
This reverts commit 773e9cc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehiko zehiko zehiko approved these changes

Assignees
No one assigned
Labels
dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @zehiko