Skip to content

Fix getAttribute return type #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
Merged

Fix getAttribute return type #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c1cc69
Fix getAttribute return type
nojaf Jul 3, 2025
df58e03
Format test file
nojaf Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DOMAPI/Element.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Returns element's first attribute whose qualified name is qualifiedName, and nul
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Element/getAttribute)
*/
@send
external getAttribute: (T.t, string) => string = "getAttribute"
external getAttribute: (T.t, string) => null<string> = "getAttribute"

/**
Returns the qualified names of all element's attributes. Can contain duplicates.
Expand Down
12 changes: 12 additions & 0 deletions tests/DOMAPI/Element__test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tests/DOMAPI/Element__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
external myElement: DOMAPI.element = "myElement"

switch myElement->Element.getAttribute("foo") {
| Null.Value(value) => value->Console.log
| Null => "nothing"->Console.log
}