Skip to content

Conversation

nojaf
Copy link
Member

@nojaf nojaf commented Nov 19, 2024

This uses the same

module Impl = (
  T: {
    type t
  },
) => {

trick like in #13.

So much code is deduplicated because of this.
@zth I strongly feel like we should do this.
Improving a binding in a base interface nicely ripples through to all the inheriting interfaces.

image

@nojaf
Copy link
Member Author

nojaf commented Nov 20, 2024

So, I slept on this and maintenance-wise I feel like we should go for this.

@nojaf nojaf merged commit fb395c3 into main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant