Skip to content

Improve Formdata overloads #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Improve Formdata overloads #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62543f2
Improve FormData.get
nojaf Apr 29, 2025
05c2904
Format canvas test
nojaf Apr 29, 2025
f813554
Rename other overloads
nojaf Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/FetchAPI/FormData.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ external append: (formData, ~name: string, ~value: string) => unit = "append"
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/append)
*/
@send
external append2: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit =
external appendBlob: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit =
"append"

/**
Expand All @@ -31,13 +31,13 @@ external delete: (formData, string) => unit = "delete"
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/get)
*/
@send
external get: (formData, string) => file = "get"
external get: (formData, string) => string = "get"

/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/get)
*/
@send
external get2: (formData, string) => string = "get"
external getFile: (formData, string) => file = "get"

/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/getAll)
Expand All @@ -61,4 +61,4 @@ external set: (formData, ~name: string, ~value: string) => unit = "set"
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/set)
*/
@send
external set2: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit = "set"
external setBlob: (formData, ~name: string, ~blobValue: blob, ~filename: string=?) => unit = "set"
8 changes: 7 additions & 1 deletion tests/DOMAPI/HTMLCanvasElement__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,10 @@ switch ctx.fillStyle->FillStyle.decode {
}

let img: DOMAPI.htmlImageElement = document->Document.createElement("img")->Obj.magic
ctx->CanvasRenderingContext2D.drawImageWithDimensions(~image=img, ~dx=0., ~dy=0., ~dw=200., ~dh=200.)
ctx->CanvasRenderingContext2D.drawImageWithDimensions(
~image=img,
~dx=0.,
~dy=0.,
~dw=200.,
~dh=200.,
)
15 changes: 15 additions & 0 deletions tests/FetchAPI/FormData__test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions tests/FetchAPI/FormData__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/* This works when your form has an id of "myForm" */
@scope(("document", "forms"))
external myForm: DOMAPI.htmlFormElement = "myForm"

let formData = FormData.make(~form=myForm)
let phone = formData->FormData.get("phone")
let image = formData->FormData.getFile("image")
Loading