Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document API change in ReScript 10.0.0 #551

Closed
harry-xm opened this issue Sep 8, 2022 · 1 comment · Fixed by #559
Closed

Document API change in ReScript 10.0.0 #551

harry-xm opened this issue Sep 8, 2022 · 1 comment · Fixed by #559
Milestone
v10.0

Comments

@harry-xm
Copy link

harry-xm commented Sep 8, 2022 •
edited
Loading

pages/docs/manual/latest/api/js/string-2.mdx and string.mdx should be updated to reflect breaking API change.

In rescript@9.1.4, function signature of Js.String2.match_ is (Js.String2.t, Js.Re.t) => option<array<Js.String2.t>>.

In rescript@10.0.1, the function signature has one more nested option<> as follows.

(
  Js.String2.t,
  Js.Re.t,
) => option<array<option<Js.String2.t>>>

Copied from rescript-lang/rescript#5643.
@cristianoc cristianoc added this to the v10.0 milestone Sep 8, 2022
@danielo515
Copy link

I was going crazy about this. Thanks for the bug report

weakish added a commit to weakish/rescript-lang.org that referenced this issue Sep 18, 2022
@weakish
Update Js.String[2].match_ return type
388be3e 
`Js.String2.match_` and `Js.String.match_` return type was changed
in rescript-lang/rescript#5070 and released on 10.0.0.

This commit updates the API documentation.

close rescript-lang#551
@weakish weakish mentioned this issue Sep 18, 2022
Merged
cristianoc pushed a commit that referenced this issue Sep 18, 2022
@weakish @cristianoc
Update Js.String[2].match_ return type
231471c 
`Js.String2.match_` and `Js.String.match_` return type was changed
in rescript-lang/rescript#5070 and released on 10.0.0.

This commit updates the API documentation.

close #551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.0
Development

Successfully merging a pull request may close this issue.

Update Js.String[2].match_ return type weakish/rescript-lang.org
3 participants
@danielo515 @cristianoc @harry-xm