Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant docs #740

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Variant docs #740

merged 5 commits into from
Nov 2, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Nov 2, 2023

Closes #732
Closes #734
Closes #733
Closes #731

@zth
Copy link
Collaborator Author

zth commented Nov 2, 2023

@fhammerschmidt any idea why the tests fail?

Also cc @cknitt @ryyppy for review.

@fhammerschmidt
Copy link
Member

Because I did not manage to finish the test script adaptions for RescriptCore yet. I asked in Discord how to fix an error but got no answer.

pages/docs/manual/latest/variant.mdx Outdated Show resolved Hide resolved
@zth zth merged commit 1bf628f into rescript-11 Nov 2, 2023
0 of 2 checks passed
@zth zth deleted the variant-docs-2 branch November 2, 2023 12:17
fhammerschmidt pushed a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Nov 14, 2023
* untagged variants

* variant type spread docs

* variant coercion

* catch-all case

* rearrange
@zth zth mentioned this pull request Nov 14, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants