Dead code analysis editor mode via reanalyze #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and reporting the results to the VSCode problems pane
…e you can activate and deactivate
cristianoc
reviewed
Dec 31, 2021
cristianoc
approved these changes
Jan 2, 2022
…, and reporting the results to the VSCode problems pane
…e you can activate and deactivate
…h/rescript-vscode into feat/dead-code-analysis-via-reanalyze
…ostics as unused code. simplify/inline a few things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a "Dead code analysis mode". When activated, the extension will run reanalyze continuously as the ReScript compiler runs, and report back any errors found directly into the editor. It'll also set up code actions leveraging the suggestions reanalyze gives for how to suppress the issues reported.
See the video below for more details.
rescript-vscode-dead-code-analysis-mode.mp4
Thank you @cristianoc for guidance both around reanalyze and details around how the extension does things.
Happy to hear any feedback or comments, and whether this is something you're interested in merging.