Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable links in hovers #585

Merged
merged 8 commits into from
Sep 15, 2022
Merged

Clickable links in hovers #585

merged 8 commits into from
Sep 15, 2022

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 13, 2022

WIP. cc @cristianoc

TODO before merge:

  • Replace hand rolled incomplete encodeURIComponent function with something robust/complete
  • Gate functionality behind some sort of flag provided by the language client, as other clients outside of VSCode might not be able to support this

image

@@ -2,6 +2,36 @@ open SharedTypes

let codeBlock code = Printf.sprintf "```rescript\n%s\n```" code

let encodeURIComponent text =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be replaced by something vastly more complete/robust. Hopefully there's something for OCaml we can find and vendor or similar.

analysis/src/Hover.ml Outdated Show resolved Hide resolved
@zth zth requested a review from cristianoc September 14, 2022 16:40
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@zth zth merged commit ae2c1d9 into master Sep 15, 2022
@zth zth deleted the links-in-hover branch September 15, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants