Fix issue with references to elements defined in an interface file #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645
References to elements defined in an interface file are not working. E.g.
The observed issue is that the locations of the references are fine, but the location of the definition in the module type is reported as being a ghost location (line -1).
This PR simply removes the ghost location from the results. Still need to look at why such ghost location is produced (go to definitions goes to the correct location in the module type).
For components, the JSX ppx produces 2 values called
make
shadowing one another, which triggers the compiler to generate a module constraint with a module type having only onemake
, and the same issue appears.