Nested expression completion #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Jan 7, 2023
cristianoc
approved these changes
Jan 8, 2023
cristianoc
reviewed
Jan 8, 2023
zth
commented
Jan 10, 2023
| @@ -931,6 +931,30 @@ let findLocalCompletionsForValuesAndConstructors ~(localTables : LocalTables.t) | |||
| (processLocalModule ~prefix ~exact ~env ~localTables); | |||
| List.rev_append localTables.resultRev valuesFromOpens | |||
|
|
|||
| let findLocalCompletionsForValues ~(localTables : LocalTables.t) ~env ~prefix | |||
There was a problem hiding this comment.
Slimmed down version of a pre-existing function (but that handles both this + constructors). We don't want constructors in typed completion, since they are handled by the typed completion itself.
zth
commented
Jan 10, 2023
| @@ -1098,6 +1122,28 @@ let extractFunctionType ~env ~package typ = | |||
| in | |||
| loop ~env [] typ | |||
|
|
|||
| let getComplementaryCompletionsForTypedValue ~opens ~allFiles ~scope ~env prefix | |||
There was a problem hiding this comment.
Also a slimmed down version of a pre-existing fn.
zth
commented
Jan 10, 2023
| @@ -1193,6 +1239,111 @@ let findReturnTypeOfFunctionAtLoc loc ~(env : QueryEnv.t) ~full ~debug = | |||
| | _ -> None) | |||
| | _ -> None | |||
|
|
|||
| let getJsxLabels ~componentPath ~findTypeOfValue ~package = | |||
zth
commented
Jan 10, 2023
| typ |> getLabels | ||
| | None -> [] | ||
|
|
||
| let getArgs ~env (t : Types.type_expr) ~full = |
cristianoc
reviewed
Jan 11, 2023
analysis/tests/src/expected/CompletionFunctionArguments.res.txt
Outdated
Show resolved
Hide resolved
… regular completions
zth
force-pushed
the
initial-expr-completion
branch
from
5a031fd to
3245210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the current expression completion to handle more cases (records, arrays, tuples, etc), and also handle nested expressions (record fields, constructor payloads, etc etc).
It's essentially a one-to-one port of the nested pattern completion, but for expressions instead.
After this lands, we can soon start refactoring and break up the giant CompletionFrontend/CompletionBackend a bit in my opinion.