Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown code block syntax highlight support #97

Merged
merged 15 commits into from
Jul 25, 2022

Conversation

wangbinyq
Copy link
Contributor

No description provided.

@wangbinyq wangbinyq changed the title add markdown code block syntax highlight support Add markdown code block syntax highlight support Mar 26, 2021
@chenglou
Copy link
Member

Hey, thanks! Though is this the idiomatic way of doing it? It seems typescript's grammar repo doesn't have such thing?

@wangbinyq
Copy link
Contributor Author

I rewrite the file from the vscode-reasonml repo, just some minor changes.

@fhammerschmidt
Copy link
Member

@zth can we get semantic highlighting in markdown blocks as well?

@zth
Copy link
Collaborator

zth commented Jul 13, 2022

@fhammerschmidt I'm not sure. Does TS do it?

@aspeddro
Copy link
Contributor

I was looking for how vscode apply syntax highlighting in markdown. It doesn't use semantic highlighting just TexMate grammar.

Here are supported languages.

@fhammerschmidt
Copy link
Member

Having at least a bit of highlighting would already be nice.
Currently it is just all the same color.

image

@zth
Copy link
Collaborator

zth commented Jul 24, 2022

I'm thinking we should merge this as is. I agree that some highlighting is better than none. Ok with you @cristianoc ?

Side note: There's more interesting things we can do eventually to better support md, like formatting code inside of ReScript md blocks.

@zth zth merged commit d180824 into rescript-lang:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants