Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit %todo istead of failwith when appropriate #981

Merged
merged 2 commits into from
May 24, 2024
Merged

Emit %todo istead of failwith when appropriate #981

merged 2 commits into from
May 24, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented May 24, 2024

This adds two things:

  1. Complete the new %todo extension point.
  2. Emit %todo instead of failwith("TODO") when on ReScript >= v11.1.

@zth zth requested a review from cristianoc May 24, 2024 13:06
@zth zth merged commit e3ee758 into master May 24, 2024
6 checks passed
@zth zth deleted the emit-todo-instead-of-failwith branch May 24, 2024 15:21
jfrolich pushed a commit to jfrolich/rescript-vscode that referenced this pull request Sep 3, 2024
@zth @jfrolich
Emit %todo istead of failwith when appropriate (rescript-lang#981)
a63150f 
* emit %todo istead of failwith when appropriate

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc