Sync rescript-editor-support #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync rescript-editor-support to commit rescript-lang/rescript-editor-support@ae455c7 Since release 1.0.5: #### New features - Add support for autocomplete for pipe-first `foo->`: the type of `foo` is used to determine the module to take completions from. - Add support for autocomplete for decorators such as `@module` and `@val`. - Add support for autocomplete of labelled arguments `foo(~label... )`. - Add support for @deprecated attributes in autocomplete and hover. - Support for upcoming `rescript` npm package for the compiler. Looks for `rescript` in addition to `bs-platform` in `node_modules`. #### Fixes - Fix issue for uncurried functions where the internal definition of `Js.Fn.arity` is shown on hover. (See rescript-lang/rescript-editor-support#62). - Fix type hint when hovering over labeled arguments of components (See rescript-lang/rescript-editor-support#63). - Fix issue where values declared with type annotation would not show up in autocomplete, and would show no doc comment on hover. (See #72). - Fix hover on definitions inside a react component module, or whenever multiple definitins for the same value exist in the module (See rescript-lang/rescript-editor-support#67). - Fix autocomplete issue where multiple open's were considered in the wrong priority order (See rescript-lang/rescript-editor-support#72). - Autocomplete: add support for `open!` in addition to `open`.
|
Updated: don't show deprecation on hover. |
|
For posteriority, this is what it looks like with duplicated warnings:
The rationale to remove it from the editor binary side, instead of on the diagnostics parsing side, is that the latter respects whichever bsconfig setting regarding suppressing deprecation warnings. Although the former looks better in the screenshot... |
chenglou
deleted the
rescript-editor-support-ae455c735da3f82dd8cabcd3fe82b3b294ece45c
branch
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync rescript-editor-support to commit rescript-lang/rescript-editor-support@03ee0d9
[Update: don't show deprecation on hover].
Since release 1.0.5:
New features
foo->: the type offoois used to determine the module to take completions from.@moduleand@val.foo(~label... ).rescriptnpm package for the compiler. Looks forrescriptin addition tobs-platforminnode_modules.Fixes
Js.Fn.arityis shown on hover. (See Js.arity<..> should not be visible rescript-editor-support#62).open!in addition toopen.