Use identifier loc in certain scenarios #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ios, when in incremental type checking mode
zth
force-pushed
the
use-loc-in-incremental-mode
branch
from
a5ecfc3 to
0bac95f
Compare
cristianoc
approved these changes
May 28, 2024
jfrolich
pushed a commit
to jfrolich/rescript-vscode
that referenced
this pull request
Sep 3, 2024
* use identifier location to look up type information in certain scenarios, when in incremental type checking mode * changelog * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in the code. A small adaption in incremental type checking mode that'll hopefully lead to more and more accurate completions.