Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx-specs field in build schema #3482

Closed
alex35mil opened this issue Apr 9, 2019 · 6 comments
Closed

ppx-specs field in build schema #3482

alex35mil opened this issue Apr 9, 2019 · 6 comments
Labels
enhancement priority:high stale Old issues that went stale

Comments

@alex35mil
Copy link
Contributor

In bsconfig.json schema there is sources[].ppx-specs field (screen: https://cl.ly/f27b32a53e7b).

I assumed this is ppx-flags but on a source level and I tried to apply ppx only to dev source folder but it doesn't seem to work.

  "name": "bs-log",
  "sources": [
    "src",
    {
      "dir": "examples",
      "type" : "dev",
      "ppx-specs": [
        "./_esy/ppx/build/default/bin/bin.exe"
      ]
    }
  ],
@bobzhang
Copy link
Member

@alexfedoseev , it turns out it is a feature that we want to support, but not supported yet, sorry for the confusion, will remove it from the docs at this time. How is it different from applying ppx-flags globally?

bobzhang added a commit that referenced this issue Apr 29, 2019
bobzhang added a commit that referenced this issue Apr 29, 2019
@alex35mil
Copy link
Contributor Author

@bobzhang This is library and I need to run ppx on examples only, not on the library modules.

@bobzhang
Copy link
Member

@alexfedoseev I will add a field ppx-dev-flags, so that it will only be needed in dev dependencies

@bobzhang
Copy link
Member

@alexfedoseev The challenging part is that it is hard to specify .merlin file, editor support

@aantron
Copy link

aantron commented Mar 26, 2020

FYI for anyone else watching this issue, the .merlin file question can be resolved by generating .merlin files in each directory (as Dune does), rather than one global one.

@stale
Copy link

stale bot commented May 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Old issues that went stale label May 3, 2023
@stale stale bot closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:high stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

3 participants