Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove OCaml stdlib functions #5779

Closed
cknitt opened this issue Nov 6, 2022 · 3 comments · Fixed by #6984
Closed

Deprecate/remove OCaml stdlib functions #5779

cknitt opened this issue Nov 6, 2022 · 3 comments · Fixed by #6984
Assignees
Milestone

Comments

@cknitt
Copy link
Member

cknitt commented Nov 6, 2022

As discussed with @zth: We should deprecate most functions from the OCaml stdlib and point people to Belt / Js.xxx2 / a new stdlib instead where appropriate.

So basically one would have to go through all files in jscomp/stdlib-406 and decide which functions are still needed. E.g. parts of Pervasives like string_of_int, print_endline, ... can be deprecated, as well as probably all functions in Array, List, Set etc. (although Array.get is a bit of a special case).

It may be tricky though where exactly to point the user in the deprecation messsage as long as there is no new stdlib in place yet.

@cknitt cknitt added this to the v11.0 milestone Nov 6, 2022
@cknitt cknitt changed the title Depreacte OCaml stdlib functions Deprecate OCaml stdlib functions Nov 25, 2022
@cknitt
Copy link
Member Author

cknitt commented Apr 11, 2023

I think this is something for later on when Core is moved into the compiler. Moving to v12.

@cknitt cknitt modified the milestones: v11.0, v12 Apr 11, 2023
@cknitt cknitt changed the title Deprecate OCaml stdlib functions Deprecate/remove OCaml stdlib functions Aug 25, 2024
@cknitt
Copy link
Member Author

cknitt commented Aug 25, 2024

Or already fully remove the OCaml stdlib + related primitives in v12, which would make revamping the stdlibs build procedure (#6826) much easier.

@cknitt
Copy link
Member Author

cknitt commented Aug 25, 2024

Related: We will still need some sort of Pervasives and need to decide what should stay in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants