-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up tests in jscomp/test
#6969
Comments
Can we wait for #6899 so that the changes don't conflict? I honestly want to completely restructure the tests, not just change the format. There are many tests there that don't actually have a runtime, so it's like build_tests with default config. |
I would like to get at least the Belt tests converted to the node test runner soon so that I can add them more easily to https://github.com/rescript-lang/experimental-rescript-stdlib-build. I had problems with the weird |
Nevermind. Some module resolutions might change in #6899. But that's |
While I still think that the tests could need some cleanup, what I described here is completely outdated and largely obsolete after the recent changes on master. Removal of the OCaml standard library is done, and runtime and tests are already built with bsb. So I'll close this issue. |
As part of the effort to get rid of ninja.js for building the stdlibs and tests, the files in
jscomp/test
need to be cleaned up.Note that due to ninja.js weirdness, there are currently some restrictions:
jscomp/test
.Tests are in the process of being converted from mocha (
Mt.*
) to the node test runner (Node_test.*
/Node_assert.*
).Currently, mocha test files need to have the suffix
_test
and node test files need to have_ntest
.Proposed cleanup plan:
belt_
: tests for theBelt
namespacejs_
: tests for theJs
namespaceruntime_
: tests for the compiler runtime (Curry etc.)ocaml_
: tests for the OCaml standard librarytestutil_
(?): files containing only utility functions used by testsoutput_
: test files that do not call any actual test functions and are just here to be able to manually verify changes in the compiler output_test
suffix./cc @cometkim @fhammerschmidt
The text was updated successfully, but these errors were encountered: