--create-sourcedirs fails with symlink package

[nojaf]

Doing a build with rewatch will not create the lib/bs/.sourcedirs.json file, which reanalyze needs.

rescript/compiler/bsb/bsb_watcher_gen.ml

Lines 31 to 49 in 9f65d3d

	let generate_sourcedirs_meta ~name (res : Bsb_file_groups.t) =
	let v =
	kvs
	[
	("dirs", arr (Ext_array.of_list_map res.files (fun x -> str x.dir)));
	( "generated",
	arr
	(Array.of_list
	@@ Ext_list.fold_left res.files [] (fun acc x ->
	Ext_list.flat_map_append x.generators acc (fun x ->
	Ext_list.map x.output str))) );
	( "pkgs",
	arr
	(Array.of_list
	(Bsb_pkg.to_list (fun pkg path ->
	arr [|str (Bsb_pkg_types.to_string pkg); str path|]))) );
	]
	in
	Ext_json_noloc.to_file name v

should be ported as well.

[Bushuo]

There is a --create-sourcedirs flag for the build command. Is bsb doing that automatically?

[nojaf]

Ah crap 😅. Yeah bsb does this by default.

[nojaf]

Okay, there is still an issue with my setup.
So I have:

  "dependencies": {
    "@nojaf/rescript-kaplay": "link:@nojaf/rescript-kaplay",
    "kaplay": "^4000.0.0-alpha.19",
    "rescript": "12.0.0-beta.2"
  },

in package.json, node_modules/@nojaf/rescript-kaplay is actually a symlink to another full path on my disk.

Then,

rescript/rewatch/src/sourcedirs.rs

Line 24 in 38414ac

let relative_path = package.path.strip_prefix(&root_package_path).unwrap();

will panic because I can't strip the prefix.

Even when resolving the panic, that file is all empty data for me:

{"dirs":[],"generated":[],"pkgs":[]}

[nojaf]

This also seems wrong:

rescript/rewatch/src/sourcedirs.rs

Line 68 in 38414ac

.filter(|(_name, package)| !package.is_root)

in my case, my project only has a single rescript.json. So it is root, but that is okay to proceed.