Placement of closing > in JSX

[alex35mil]

There is an old issue that is still relevant.

Can we reconsider formatting of the closing > in JSX by moving it to a new line in multiline components?

[zth]

What you're proposing is what JS/TS formatters typically do for JSX, correct?

[alex35mil]

@zth yeah, exactly. Currently, it's a pain if I want to add/move/comment/delete the last prop because it requires repositioning/recreating > after a change.

[zth]

I think this is reasonable, and probably preferable to the current state, if this is what JS/TS formatters typically do.

@fhammerschmidt @nojaf any thoughts?

EDIT: I believe this would be beneficial for LLMs as well. They get tripped up by this fairly often in my experience (but can recover, just that it requires more tab completions).

[nojaf]

I suspect the current state exists because it was simpler to implement in res_printer.ml. I am open to revisiting this.

[fhammerschmidt]

I have nothing against that - except that it will result in a lot of formatting changes. But if it helps even LLMs and is more consistent with the JS ecosystem we should strongly consider it.

Also yes, personally I always forget about it but I too am annoyed by the repositioning needs of >.

[zth]

Well done @nojaf ! 🎉