Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Js.String.match_ return type #5070

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Fix Js.String.match_ return type #5070

merged 1 commit into from
Apr 18, 2021

Commits on Apr 14, 2021

  1. Fix Js.String.match_ return type 

    Javscript String.prototype.match function can
return undefined values for optional capture groups
that are not found, which breaks the type annotations
since this is not added as a Js.nullable or an option,
it's not possible to deal with those.

Added an option type for array values.
    @renatoalencar
    renatoalencar committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    5ae4b1b View commit details
    Browse the repository at this point in the history