Skip to content

Sync belt doc headers for Option #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2022
Merged

Sync belt doc headers for Option #5424

merged 2 commits into from
Jun 13, 2022

Conversation

@nkrkv
Copy link
Contributor

@nkrkv nkrkv commented Jun 10, 2022

Am I doing it right?

Namely:

@nkrkv nkrkv mentioned this pull request Jun 10, 2022
Merged
35 tasks
@ryyppy
Copy link
Member

ryyppy commented Jun 13, 2022

Looking really good! I am not entirely sure about the res sig meta yet, but that's easy to refactor later on anyways.

@ryyppy ryyppy merged commit d4efae0 into rescript-lang:sync-belt-doc-headers Jun 13, 2022
@nkrkv nkrkv deleted the sync-belt-doc-headers-option branch June 13, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nkrkv @ryyppy