Skip to content

Conversation

@mununki
Copy link
Member

@mununki mununki commented Jan 28, 2023

This PR fixes #5957. The only case of the lowercase & classic mode keeps the loc and others are missing. This PR add the missing the loc of JSX call expression into all cases.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😃

@cknitt
Copy link
Member

cknitt commented Jan 28, 2023

Could you also add a changelog entry and backport to 10.1_release?

@mununki
Copy link
Member Author

mununki commented Jan 28, 2023

Could you also add a changelog entry and backport to 10.1_release?

Sure thing.

@mununki mununki merged commit ba47799 into master Jan 28, 2023
@mununki mununki deleted the add-missing-loc-jsx branch January 28, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSX4: loc missing in error for not existing prop

3 participants