Fix issue with async and locally abstract types #5982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
async_locally_abstract
branch
from
a55cf57 to
d5cc12a
Compare
cristianoc
added a commit
that referenced
this pull request
Feb 6, 2023
This is a port of the compiler part of #5982 to 10.1.
cristianoc
added a commit
that referenced
this pull request
Feb 6, 2023
This is a port of the compiler part of #5982 to 10.1.
To fix the printer, the async internal representation via an attribute needs to be preserved on functions starting with a locally abstract type. For this reason, annotations cannot be placed individually on the first locally abstract type, if that's how the function starts. Fixes #5974
cristianoc
force-pushed
the
async_locally_abstract
branch
from
d5cc12a to
db07632
Compare
cristianoc
added a commit
that referenced
this pull request
Feb 6, 2023
This is a port of the compiler part of #5982 to 10.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the printer, the async internal representation via an attribute needs to be preserved on functions starting with a locally abstract type. For this reason, annotations cannot be placed individually on the first locally abstract type, if that's how the function starts. Some printer tests of functions starting with an abstract type have changed because of this.
Fixes #5974