Fix playground build infra w/ ReScript 11

[ryyppy]

Fixes #6200

Key changes:

• Updated the generate_cmij.js script to also build a compiler-builtins/cmij.js file from the ReScript lib/ocaml modules (otherwise the playground can't compile any ReScript programs due to missing core modules like Pervasives)
• Added @rescript/core as a pre-vendored package
• Playground bundle and pre-built third party cmijs default to uncurried mode
• Streamlined development by adding relevant Makefile targets
• Also updated the CONTRIBUTING file to reflect the latest changes
• Remove the outdated jsoo_main.ml / jsoo_common infra (and use js_of_ocaml as a library instead)

There's quite some potential making the playground e2e tests more rigorous by re-using existing compiler tests and passing them to the JSOOified compiler APIs as strings.

[cknitt]

Thanks for this! 🎉

[cristianoc]

I get errors with:

make playground-cmijs

<<<<<<
>>>>>> running command: find /Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/node_modules/rescript/lib/ocaml -name "*.cmi" -or -name "*.cmj" | xargs -n1 basename | xargs js_of_ocaml build-fs -o /Users/cristianocalcagno/GitHub/rescript-compiler/playground/packages/compilerCmij.js -I /Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/node_modules/rescript/lib/ocaml
<<<<<<
>>>>>> running command: find /Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/node_modules/@rescript/react/lib/es6 -name '*.js' -exec cp {} /Users/cristianocalcagno/GitHub/rescript-compiler/playground/packages/@rescript/react \;
find: /Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/node_modules/@rescript/react/lib/es6: No such file or directory
node:child_process:960
    throw err;
    ^

Error: Command failed: find /Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/node_modules/@rescript/react/lib/es6 -name '*.js' -exec cp {} /Users/cristianocalcagno/GitHub/rescript-compiler/playground/packages/@rescript/react \;
    at checkExecSyncError (node:child_process:885:11)
    at Object.execSync (node:child_process:957:15)
    at e (/Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/scripts/generate_cmijs.js:45:17)
    at installLib (/Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/scripts/generate_cmijs.js:100:5)
    at Array.forEach (<anonymous>)
    at buildThirdPartyCmijs (/Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/scripts/generate_cmijs.js:73:12)
    at Object.<anonymous> (/Users/cristianocalcagno/GitHub/rescript-compiler/packages/playground-bundling/scripts/generate_cmijs.js:108:1)
    at Module._compile (node:internal/modules/cjs/loader:1205:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1259:10) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 67434,
  stdout: null,
  stderr: null
}

[ryyppy]

@cristianoc Found the issue. Could you try again and see if it works on your machine?

[cristianoc]

@cristianoc Found the issue. Could you try again and see if it works on your machine?

Works.

There are a few warnings.

These jump to the eye:

Warning: integer overflow: integer 0x100000000 (4294967296) truncated to 0x0 (0); the generated code might be incorrect.
Warning: integer overflow: integer 0x100000000 (4294967296) truncated to 0x0 (0); the generated code might be incorrect.

I guess they might be jsoo warnings. And probably does not matter.

[cristianoc]

ocsigen/js_of_ocaml#285

The location information does not exactly help.
I'd say let's ignore it unless something strange is observed in the playground.

[cristianoc]

To please CI:

npm run format

[cknitt]

I guess they might be jsoo warnings. And probably does not matter.

These warnings only occur when building with jsoo, and they have been there "forever" (before moving to the dune-based build setup).

[ryyppy]

These warnings only occur when building with jsoo, and they have been there "forever" (before moving to the dune-based build setup).

Yes, in fact I actually find these errors useful to know that jsoo actually did its work.

I will still need to adapt the compiled files to uncurried mode.

[ryyppy]

Force-pushed to latest master. There's still some issue when trying to compile useState (which causes a Stack Overflow error), so will investigate a little more before marking this as ready.

[mununki]

Force-pushed to latest master. There's still some issue when trying to compile useState (which causes a Stack Overflow error), so will investigate a little more before marking this as ready.

I stumbled upon this while testing, and it seems to cause a stack overflow error if there is an unused value. If I replace it with this, I don't get the error.

let _ = React.useState(_ => 0)

[ryyppy]

The issue was caused by the overloaded warning printer logic. Fixed in f75fbf0.

[cknitt]

Great work! Thanks a lot! ❤️

[cristianoc]

Go for it.

[ryyppy]

Re-based onto master again and adjusted the code to use the adapted error reporter. Ready to be merged now.