-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rescript.json
#6382
Support rescript.json
#6382
Conversation
Note: This is essential to supporting the 1. BackportingDo we need it for v10? 2. Simplifying configThe config is currently over-bloated. There are many variants of config structure, recursive definitions, deprecated features, and even undocumented features no one uses. It adds a lot of complexity to the codebase, making refactoring and third-party replication difficult. Here's a list we can point out:
And maybe we can remove all the 3. Refactoring planIn the current codebase, the loading and parsing of I suggested separating "config" and "manifest" in my previous PR.
Making manifest input pure logic can make it easier to reuse, and perhaps we can publish it to opam so third-party tools can use it. 4. MigrationThis PR simply adds the printing message It may be sufficient since 5. Further works
|
4bcfc66
to
f88643e
Compare
f88643e
to
3d75e71
Compare
Just rebased PR. I think this can be included in v11.0, we can then release the new configuration in v11.x in "compat mode" No matter how we change the configuration, it should be in v12. I'll open a new issue for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! Looks good to me.
Also tested it against the project that I am currently working on.
@cristianoc @zth Anything to add from your side?
Resolves #5278
Closes #6193